gabogg/hikcentral

Watch

Fork 0

docs(agents): milestones hold only what their delivery needs #266

Merged

gabogg merged 2 commits from docs/milestone-membership-rule into master

2026-10-03 12:41:27 +00:00

gabogg commented

2026-10-03 12:21:13 +00:00

Owner

Summary

Tightens milestone membership to the maintainer's rule from 2026-10-03: an issue or PR joins a milestone only if the milestone cannot be completed without it.

The old rule put every review follow-up into its umbrella's milestone. Milestone 1 (historical backfill) had gathered 22 P3 follow-ups (refactors, test gaps, docs nits, UI polish), so its open count no longer reflected the work left to deliver the feature.

docs/agents/milestones.md (Membership):
- States the rule.
- Review follow-ups stay out by default. One joins only when the delivery depends on it, and the issue says why.
- A PR that closes only out-of-milestone issues stays out too.
AGENTS.md: the Milestones pointer now says the same in one line.

Tracker changes already applied (not versioned)

Milestone 1: removed #182, #183, #184, #213–#215, #223–#226, #244, #245, #247 and #249–#257, plus PR #222. Kept:
- the umbrella #160 and the core issues #163–#165;
- #186 (a prerequisite: audit actions and FREEZE on existing DBs);
- #246 (backfilled days have no frozen record, so the readers would split);
- the PRs #170–#172 and #228.
Milestone 2: #197 (role authorization) joined as a prerequisite, and the milestone description names it.
Removed blocked from #163 and #164, since all their prerequisites have merged.

Verification

scripts/check_docs.py: 43 Markdown files and 90 HTTP operations, passed.

🤖 Generated with Claude Code

## Summary Tightens milestone membership to the maintainer's rule from 2026-10-03: **an issue or PR joins a milestone only if the milestone cannot be completed without it.** The old rule put every review follow-up into its umbrella's milestone. Milestone 1 (historical backfill) had gathered 22 P3 follow-ups (refactors, test gaps, docs nits, UI polish), so its open count no longer reflected the work left to deliver the feature. - `docs/agents/milestones.md` (Membership): - States the rule. - Review follow-ups stay out by default. One joins only when the delivery depends on it, and the issue says why. - A PR that closes only out-of-milestone issues stays out too. - `AGENTS.md`: the Milestones pointer now says the same in one line. ## Tracker changes already applied (not versioned) - **Milestone 1:** removed #182, #183, #184, #213–#215, #223–#226, #244, #245, #247 and #249–#257, plus PR #222. Kept: - the umbrella #160 and the core issues #163–#165; - #186 (a prerequisite: audit actions and FREEZE on existing DBs); - #246 (backfilled days have no frozen record, so the readers would split); - the PRs #170–#172 and #228. - **Milestone 2:** #197 (role authorization) joined as a prerequisite, and the milestone description names it. - Removed `blocked` from #163 and #164, since all their prerequisites have merged. ## Verification - `scripts/check_docs.py`: 43 Markdown files and 90 HTTP operations, passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

gabogg added the

ready-for-agent

label

2026-10-03 12:21:13 +00:00

gabogg added 1 commit

2026-10-03 12:21:13 +00:00

docs(agents): milestones hold only what their delivery needs

CI / lint-and-test (pull_request) Successful in 3m9s

Details

0bc77dab29

An issue or PR joins a milestone only if the milestone cannot be
completed without it. Review follow-ups (P3 polish, refactors, test
gaps, docs nits) stay outside by default; one joins only when the
delivery depends on it, with the reason stated in the issue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

gabogg added 1 commit

2026-10-03 12:37:59 +00:00

docs(agents): tighten milestone membership wording

CI / lint-and-test (pull_request) Successful in 3m8s

Details

9b7dd70bba

Fix a sentence fragment, apply the rule to split items, and drop
"at creation" from the AGENTS.md pointer, since prerequisites join later.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

gabogg reviewed

2026-10-03 12:38:16 +00:00

gabogg left a comment

Code review, pass 1 (`origin/master...0bc77da`, spec: maintainer milestone rule of 2026-10-03)

Result: no P1 or P2, and 5 P3s. Three are fixed in 9b7dd70, and two needed tracker or cross-PR changes. Mergeable.

check_docs passes. The PR merges cleanly, and nothing elsewhere contradicts it: git-and-workflow.md:27 and forgejo-cli.md:42–44 are consistent.

P3

Fixed in 9b7dd70:
- The sentence fragment at milestones.md:18.
- The split rule at :23 now applies the new test ("that the delivery still needs").
- The AGENTS.md pointer no longer says "at creation", since prerequisites join later.
Tracker change (not versioned): Milestone 1's description now names #186 and #246 and says why they are required.
Cross-PR: #265's rule (rfc lines 117–118) puts every research follow-up into the research milestone, which conflicts with this rule. That is raised on #265.

## Code review, pass 1 (`origin/master...0bc77da`, spec: maintainer milestone rule of 2026-10-03) Result: **no P1 or P2, and 5 P3s.** Three are fixed in `9b7dd70`, and two needed tracker or cross-PR changes. **Mergeable.** - `check_docs` passes. The PR merges cleanly, and nothing elsewhere contradicts it: `git-and-workflow.md:27` and `forgejo-cli.md:42–44` are consistent. ### P3 - **Fixed in `9b7dd70`:** - The sentence fragment at `milestones.md:18`. - The split rule at :23 now applies the new test ("that the delivery still needs"). - The AGENTS.md pointer no longer says "at creation", since prerequisites join later. - **Tracker change (not versioned):** Milestone 1's description now names #186 and #246 and says why they are required. - **Cross-PR:** #265's rule (rfc lines 117–118) puts every research follow-up into the research milestone, which conflicts with this rule. That is raised on #265.

gabogg changed title from ~~WIP: docs(agents): milestones hold only what their delivery needs~~ to docs(agents): milestones hold only what their delivery needs

2026-10-03 12:39:47 +00:00

gabogg merged commit ae8f994d04 into master

2026-10-03 12:41:27 +00:00

gabogg deleted branch docs/milestone-membership-rule

2026-10-03 12:41:27 +00:00

gabogg referenced this pull request from a commit

2026-10-03 12:41:28 +00:00

docs(agents): milestones hold only what their delivery needs (#266)

gabogg referenced this pull request

2026-10-03 12:51:45 +00:00

research(tests): faster test suite and right-sized testing for agentic workflows #217

gabogg referenced this pull request