fix(occupancy): a holiday passed with no frozen record still splits the readers #246

New issue

Open

opened 2026-10-03 08:47:09 +00:00 by gabogg · 0 comments

gabogg commented

2026-10-03 08:47:09 +00:00

Owner

P3 follow-up from PR #178 review pass 4 (spec axis). Plausible, not reproduced.

Finding

Decision 1 (2026-10-02) says: "There must be one source of holiday identity, not two that can disagree." One narrow gap remains:

Scenario: the monitor is down for the whole holiday, so monitor_service.py:114 never freezes the day. Calibration history for that day is backfilled later.
The readers disagree:
- The calibration schedule fallback (occupancy_service.py ~565-590) reads occupancy_holidays and says holiday.
- Learning (occupancy_repository.py ~2842) and the spike reference (~3135) read only the business-day records, so they count the day as ordinary.

Acceptance Criteria

Reproduce the scenario in a test (missed freeze, then backfill).
Close the gap: stamp the day when history first lands for it, or make every reader resolve through the same path. All readers then agree the day is a holiday.

P3 follow-up from PR #178 review pass 4 (spec axis). Plausible, not reproduced. ### Finding Decision 1 (2026-10-02) says: "There must be one source of holiday identity, not two that can disagree." One narrow gap remains: - **Scenario:** the monitor is down for the whole holiday, so `monitor_service.py:114` never freezes the day. Calibration history for that day is backfilled later. - **The readers disagree:** - The calibration schedule fallback (`occupancy_service.py` ~565-590) reads `occupancy_holidays` and says holiday. - Learning (`occupancy_repository.py` ~2842) and the spike reference (~3135) read only the business-day records, so they count the day as ordinary. ### Acceptance Criteria - Reproduce the scenario in a test (missed freeze, then backfill). - Close the gap: stamp the day when history first lands for it, or make every reader resolve through the same path. All readers then agree the day is a holiday.

gabogg added this to the Historical passenger-flow backfill milestone

2026-10-03 08:47:09 +00:00

gabogg added the

ready-for-agent

bug

labels

2026-10-03 08:47:09 +00:00

gabogg referenced this issue

2026-10-03 12:21:13 +00:00

docs(agents): milestones hold only what their delivery needs #266

gabogg referenced this issue from a pull request that will close it,

2026-10-03 12:30:26 +00:00