fix(occupancy): stamp past holiday days atomically with the exception write #245

New issue

Open

opened 2026-10-03 08:47:08 +00:00 by gabogg · 0 comments

gabogg commented

2026-10-03 08:47:08 +00:00

Owner

P3 follow-up from PR #178 review pass 4 (both axes).

Finding

add_schedule_exception_async (app/services/occupancy_service.py ~239-249) commits the exception, then stamps the past day in a second transaction. If the stamp raises (for example in a reset race), the exception is saved but the day has no business-day record. That reopens the "readers split" defect from r32 P2-3 for that day.
The same 10-line "stamp if no record" block is repeated in classify_holiday_async (~288-299), and only the condition differs.

Acceptance Criteria

The exception write and the stamping of a completed day are one transaction, or the stamp failure rolls back the exception.
One helper (for example _ensure_completed_day_stamped(day, actor, reason)) is used by both call sites.
A test with an injected stamp failure leaves no orphan exception and no missing record.

P3 follow-up from PR #178 review pass 4 (both axes). ### Finding - `add_schedule_exception_async` (`app/services/occupancy_service.py` ~239-249) commits the exception, then stamps the past day in a second transaction. If the stamp raises (for example in a reset race), the exception is saved but the day has no business-day record. That reopens the "readers split" defect from r32 P2-3 for that day. - The same 10-line "stamp if no record" block is repeated in `classify_holiday_async` (~288-299), and only the condition differs. ### Acceptance Criteria - The exception write and the stamping of a completed day are one transaction, or the stamp failure rolls back the exception. - One helper (for example `_ensure_completed_day_stamped(day, actor, reason)`) is used by both call sites. - A test with an injected stamp failure leaves no orphan exception and no missing record.

gabogg added this to the Historical passenger-flow backfill milestone

2026-10-03 08:47:08 +00:00

gabogg added the

ready-for-agent

bug

labels

2026-10-03 08:47:08 +00:00

gabogg removed this from the Historical passenger-flow backfill milestone

2026-10-03 12:13:36 +00:00

gabogg referenced this issue

2026-10-03 12:21:13 +00:00

docs(agents): milestones hold only what their delivery needs #266