Release: Frontend i18n, desktop table fixes, test infrastructure, and agent tooling #18
Loading…
Reference in a new issue
No description provided.
Delete branch "dev"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary of Changes (dev -> master)
This release PR promotes all completed features, bug fixes, and infrastructure improvements from
devintomaster.1. Bug Fixes & UI Enhancements
{#key currentPage}and reactive loading inListPage.svelte.locationsto/api/states./api/test/versionand/api/test/healthendpoints, enriched/api/test/infowith system diagnostics, and resolved CORS/connection issues.2. Internationalization (i18n)
typesafe-i18nwith full English (en) and Spanish (es) localization across all desktop pages, forms, scanner, toasts, and navigation.3. Testing Infrastructure & CI
desktop-pure-logicRust tests in parallel CI.4. Agent Tooling
Flaw 11 - Repetitive @JsonIgnoreProperties: Remove 'hibernateLazyInitializer' and 'handler' from all entity @JsonIgnoreProperties annotations — Hibernate6Module handles these globally via Jackson configuration. Flaw 12 - Fragile bag barcode lookup: Change endpoint from /api/bags/barcode/{barcode} (@PathVariable) to /api/bags/by-barcode?barcode= (@RequestParam) for better handling of special characters in barcodes. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>Complete E2E test suite covering every functional area: 1. Login flow + Dashboard stat cards 2. All 7 entity page renderings (Branches, Categories, Items, Bags, Roles, Users, Departments) 3. Permissions table 4. Locations page 5. Categories full CRUD: create, edit, delete 6. Filter/search within data tables (match + empty state) 7. Pagination button visibility 8. Item inline form modal (name, description, quantity fields) 9. Scanner page (camera button, help text) 10. Audit log search controls 11. All 12 sidebar nav items present + navigable without errors 12. API CRUD verification for all 5 entity types (categories, departments, items, branches, bags) 27/27 tests passing, 42.4s headed, real backend + H2 test DB + seed data. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>Assessment — recommend closing and re-splitting, don't pull as-is
Thanks for putting this together. One concrete blocker here needs its own fix before this lands on
master, and the rest is just scoping. I'd close this PR and split the work rather than pull the whole 1406-file promotion in one shot.Blocker: 1.1 GB of Rust build artifacts are being committed to
masterThe diff adds 1030 files under
desktop/pure-logic/target/— about 1.1 GB on disk, 2265 files on the filesystem. This is the only thing I'd treat as a hard "don't merge" issue:mastercurrently has 231 tracked files; this PR pushes it to ~1462, with build artifacts making up 70% of the repo.694f3b0(the "extract tauri pure-logic to standalone crate" commit) and have been tracked ondevsince..gitignorealready hastarget/and**/target/, but those rules only apply to untracked files. Once a file is tracked, gitignore can't help — so this needsgit rm -r --cached desktop/pure-logic/targetplus a commit, not another ignore rule.Every clone (and every CI run) pays for that 1.1 GB for no reason, and it's the same root cause as the oversized diffs we've been tripping over.
Why split instead of one mega-merge
The PR is four independent workstreams under a "release" label:
target/)..agents/skills/+.claude/skills/symlinks).For a one-team effort this level of batching is understandable — there's no need to enforce heavy process here. But splitting at least the build-artifact cleanup into its own fix branch is worth it, because it's the one thing that would otherwise be permanently baked into
master's history. The rest can reasonably ride together if you want to keep the release simple.What's already clean (not blockers)
JWT_SECRETis a clearly-labeled test value, and the rest of the secret-scan hits are documentation text..agents/skillsis now tracked, so the.claude/skills/*links resolve.staged_diff*.patch,pom.xml.versionsBackup, andtest_mcp.jsare being deleted, which is good cleanup.Recommended next step
devthat runsgit rm -r --cached desktop/pure-logic/target(plus any other stray build output), and merge that back intodev.dev → masterrelease after the artifacts are out of history — or bringmasterup in a couple of smaller slices if that's easier to review.Nothing else here is urgent; it's just the
target/commit that should not reachmaster.Resolution to Assessment:
desktop/pure-logic/target/build artifact files from the git index ondevvia6b5efcd.git ls-filesthat no other build targets,node_modules,dist/, or temporary logs are tracked.