gabogg/hv-unified
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

v0.14.34 - Fix difficulty comparison case bug

Browse source 
Bug: difficulties.indexOf(difficulty.toUpperCase()) — the array has
'Nintendo' (mixed case) but toUpperCase() gives 'NINTENDO' which
doesn't match, so currentIdx = -1 and -1 < suggestedIdx always true.
The suggestion kept firing even when already on Nintendo.
(IWBTH worked by luck since uppercase == itself.)

Fix: case-insensitive findIndex comparison on both sides.
This commit is contained in:
GaboGG 2026-07-31 07:09:30 -04:00
parent 166539e845
commit 03cbccf703
5 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
scripts/hv-unified.user.js
View file

@ -1,7 +1,7 @@
// ==UserScript== // ==UserScript==
// @name HV Unified // @name HV Unified
// @namespace hvunified // @namespace hvunified
// @version 0.14.33 // @version 0.14.34
// @description HV Unified — battle automation, guidance, and UI enhancements for HentaiVerse // @description HV Unified — battle automation, guidance, and UI enhancements for HentaiVerse
// @author GaboGG + Hermes // @author GaboGG + Hermes
// @match *://*.hentaiverse.org/* // @match *://*.hentaiverse.org/*
@ -17,7 +17,7 @@
// CONFIG — default settings // CONFIG — default settings
// ═══════════════════════════════════════════════════════════════════════ // ═══════════════════════════════════════════════════════════════════════
const VERSION = '0.14.33'; const VERSION = '0.14.34';
const CFG = { const CFG = {
// — Battle automation // — Battle automation
@ -2554,8 +2554,8 @@ function getDifficultyAdvice() {
reason = ''; reason = '';
} }
const currentIdx = difficulties.indexOf(difficulty.toUpperCase()); const currentIdx = difficulties.findIndex(d => d.toLowerCase() === (difficulty || '').toLowerCase());
const suggestedIdx = difficulties.indexOf(suggested); const suggestedIdx = difficulties.findIndex(d => d.toLowerCase() === suggested.toLowerCase());
// Only warn if current difficulty is LOWER than suggested // Only warn if current difficulty is LOWER than suggested
// (don't nag if you're already on a higher difficulty) // (don't nag if you're already on a higher difficulty)

8
scripts/latest.user.js
View file

@ -1,7 +1,7 @@
// ==UserScript== // ==UserScript==
// @name HV Unified // @name HV Unified
// @namespace hvunified // @namespace hvunified
// @version 0.14.33 // @version 0.14.34
// @description HV Unified — battle automation, guidance, and UI enhancements for HentaiVerse // @description HV Unified — battle automation, guidance, and UI enhancements for HentaiVerse
// @author GaboGG + Hermes // @author GaboGG + Hermes
// @match *://*.hentaiverse.org/* // @match *://*.hentaiverse.org/*
@ -17,7 +17,7 @@
// CONFIG — default settings // CONFIG — default settings
// ═══════════════════════════════════════════════════════════════════════ // ═══════════════════════════════════════════════════════════════════════
const VERSION = '0.14.33'; const VERSION = '0.14.34';
const CFG = { const CFG = {
// — Battle automation // — Battle automation
@ -2554,8 +2554,8 @@ function getDifficultyAdvice() {
reason = ''; reason = '';
} }
const currentIdx = difficulties.indexOf(difficulty.toUpperCase()); const currentIdx = difficulties.findIndex(d => d.toLowerCase() === (difficulty || '').toLowerCase());
const suggestedIdx = difficulties.indexOf(suggested); const suggestedIdx = difficulties.findIndex(d => d.toLowerCase() === suggested.toLowerCase());
// Only warn if current difficulty is LOWER than suggested // Only warn if current difficulty is LOWER than suggested
// (don't nag if you're already on a higher difficulty) // (don't nag if you're already on a higher difficulty)

2
src/config.js
View file

@ -2,7 +2,7 @@
// CONFIG — default settings // CONFIG — default settings
// ═══════════════════════════════════════════════════════════════════════ // ═══════════════════════════════════════════════════════════════════════
const VERSION = '0.14.33'; const VERSION = '0.14.34';
const CFG = { const CFG = {
// — Battle automation // — Battle automation

4
src/guidance.js
View file

@ -62,8 +62,8 @@ function getDifficultyAdvice() {
reason = ''; reason = '';
} }
const currentIdx = difficulties.indexOf(difficulty.toUpperCase()); const currentIdx = difficulties.findIndex(d => d.toLowerCase() === (difficulty || '').toLowerCase());
const suggestedIdx = difficulties.indexOf(suggested); const suggestedIdx = difficulties.findIndex(d => d.toLowerCase() === suggested.toLowerCase());
// Only warn if current difficulty is LOWER than suggested // Only warn if current difficulty is LOWER than suggested
// (don't nag if you're already on a higher difficulty) // (don't nag if you're already on a higher difficulty)

2
src/header.user.js
View file

@ -1,7 +1,7 @@
// ==UserScript== // ==UserScript==
// @name HV Unified // @name HV Unified
// @namespace hvunified // @namespace hvunified
// @version 0.14.33 // @version 0.14.34
// @description HV Unified — battle automation, guidance, and UI enhancements for HentaiVerse // @description HV Unified — battle automation, guidance, and UI enhancements for HentaiVerse
// @author GaboGG + Hermes // @author GaboGG + Hermes
// @match *://*.hentaiverse.org/* // @match *://*.hentaiverse.org/*