gabogg/hikcentral
Watch
1
0
Fork
You've already forked hikcentral
 0
Code Issues 113 Pull requests 8 Projects Releases Packages Wiki Activity Actions

chore(i18n): finish the business cycle wording sweep and fix the working-hours label #258

New issue
Closed
opened 2026-10-03 10:45:38 +00:00 by gabogg · 1 comment
gabogg commented 2026-10-03 10:45:38 +00:00
Owner
Copy link

P3 follow-up from PR #243 review pass 2 (spec axis). Spec #49: "single canonical English term everywhere ... admin labels, KPI copy".

Finding

  • A mistranslation (fix first). occupancy_service.py:774 renders the WORKING_HOURS preset ("Jornada Comercial - ...") as "Business cycle working hours - ...". Here jornada comercial means opening hours, and i18n.js:1222 maps the same phrase to "Working Hours". tests/test_business_cycle_labels.py:55 locks the wrong string in. The label should be "Working hours - {schedule}".

  • English copy still using other terms:

    • i18n.js:1283 nocturnalCycleAndCalibTitle "Reset Cycle & Nocturnal Calibration"
    • bare "cycle" at :1280 "SPIKE WINDOW (CYCLES)", :2216 "Cycle / Time" and :2239-2240 "Trusted cycle..." / "Excluded or anomalous cycle..."
    • CONTEXT.md:166 "normal operating cycle", which contradicts its own _Avoid_ line at :191
    • README.md:11 "operational cycles"
    • a command_deck_adapter.js:1597 comment

  • Spanish copy still translating the retired English term:

    • operationalCycle "Ciclo Operativo" (:84)
    • operatingCycle "CICLO_OPERATIVO:" (:337)
    • peakTooltip (:336), modalRetroactiveDateLabel (:1042) and "Últimos 14 ciclos" (:1066)

    CONTEXT.md:190 says Spanish display text calls the concept "jornada".

Acceptance Criteria

  • The working-hours label is fixed, along with its test.
  • English copy uses "business cycle" wherever this concept is meant. A bare "cycle" is fine only where "business cycle" is already clear from context. Door access cycles stay untouched.
  • Spanish copy for this concept uses jornada(s).
P3 follow-up from PR #243 review pass 2 (spec axis). Spec #49: *"single canonical English term everywhere ... admin labels, KPI copy"*. ### Finding - **A mistranslation (fix first).** `occupancy_service.py:774` renders the WORKING_HOURS preset ("Jornada Comercial - ...") as "Business cycle working hours - ...". Here *jornada comercial* means opening hours, and i18n.js:1222 maps the same phrase to "Working Hours". `tests/test_business_cycle_labels.py:55` locks the wrong string in. The label should be "Working hours - {schedule}". - **English copy still using other terms:** - i18n.js:1283 `nocturnalCycleAndCalibTitle` "Reset Cycle & Nocturnal Calibration" - bare "cycle" at :1280 "SPIKE WINDOW (CYCLES)", :2216 "Cycle / Time" and :2239-2240 "Trusted cycle..." / "Excluded or anomalous cycle..." - CONTEXT.md:166 "normal operating cycle", which contradicts its own `_Avoid_` line at :191 - README.md:11 "operational cycles" - a `command_deck_adapter.js:1597` comment - **Spanish copy still translating the retired English term:** - `operationalCycle` "Ciclo Operativo" (:84) - `operatingCycle` "CICLO_OPERATIVO:" (:337) - `peakTooltip` (:336), `modalRetroactiveDateLabel` (:1042) and "Últimos 14 ciclos" (:1066) CONTEXT.md:190 says Spanish display text calls the concept "jornada". ### Acceptance Criteria - The working-hours label is fixed, along with its test. - English copy uses "business cycle" wherever this concept is meant. A bare "cycle" is fine only where "business cycle" is already clear from context. Door access cycles stay untouched. - Spanish copy for this concept uses jornada(s).
gabogg commented 2026-10-03 10:52:03 +00:00
Author
Owner
Copy link

Folded into PR #222 (maintainer decision, 2026-10-03). It's the same i18n surface: i18n.js, index.html and the occupancy labels. #222 must merge after #243, and closes this issue.

Folded into PR #222 (maintainer decision, 2026-10-03). It's the same i18n surface: i18n.js, index.html and the occupancy labels. #222 must merge **after** #243, and closes this issue.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
docs/test-policy-217
feat/historical-flow-publication
feat/historical-flow-curation
fix/holiday-stamping-followups
chore/schedule-p3-followups-186
fix/test-isolation
test/silent-camera-trace-199
feat/historical-flow-statistics
No results found.
Labels
Clear labels   
blocked
Waits on the issues listed in its "Blocked by:" line before implementation

  
bug
Category: something is broken; behaviour differs from the spec or docs

  
enhancement
Category: new feature or improvement, including refactors, chores and docs

  
high-priority
Address before ordinary-priority work; independent of triage readiness and blockers

  
low-priority
Address after ordinary-priority work; independent of triage readiness and blockers

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
referenced
Previously closed issue reopened or referenced by an open issue; visible history marker

  
research
Needs investigation (internet or local resources) before it can be triaged down; used alongside a category and a triage role

  
wontfix
Will not be actioned

No labels
blocked
bug
enhancement
high-priority
low-priority
needs-info
needs-triage
ready-for-agent
ready-for-human
referenced
research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gabogg/hikcentral#258
No description provided.