gabogg/hikcentral
Watch
1
0
Fork
You've already forked hikcentral
 0
Code Issues 113 Pull requests 8 Projects Releases Packages Wiki Activity Actions

refactor(occupancy): consolidate multiplier re-evaluation pipeline between service and callback #253

New issue
Open
opened 2026-10-03 09:12:13 +00:00 by gabogg · 0 comments
gabogg commented 2026-10-03 09:12:13 +00:00
Owner
Copy link

Follow-up for PR #177 (next-day settings activation, #114) addressing pass-4 review finding P3-6:

Scope

In app/services/occupancy_service.py, _reeval_callback (~786) and refresh_active_multiplier_async (~1613) repeat the identical pipeline: seed retrieval, trusted calibration history, sorting, EWMA weighting with gamma 0.25, variance calculation, and configuration persistence.
The two copies have already drifted: one writes last_calibrated_at in the repository while the other writes updated_at.

Acceptance Criteria

  • Consolidate the calculation and persistence pipeline into a shared helper accepting an optional connection parameter (aiosqlite.Connection).
  • Align timestamp column updates across the unified pipeline.

Refs #177, #114.

Follow-up for PR #177 (next-day settings activation, #114) addressing pass-4 review finding P3-6: ### Scope In `app/services/occupancy_service.py`, `_reeval_callback` (~786) and `refresh_active_multiplier_async` (~1613) repeat the identical pipeline: seed retrieval, trusted calibration history, sorting, EWMA weighting with gamma 0.25, variance calculation, and configuration persistence. The two copies have already drifted: one writes `last_calibrated_at` in the repository while the other writes `updated_at`. ### Acceptance Criteria - Consolidate the calculation and persistence pipeline into a shared helper accepting an optional connection parameter (`aiosqlite.Connection`). - Align timestamp column updates across the unified pipeline. Refs #177, #114.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
docs/test-policy-217
feat/historical-flow-publication
feat/historical-flow-curation
fix/holiday-stamping-followups
chore/schedule-p3-followups-186
fix/test-isolation
test/silent-camera-trace-199
feat/historical-flow-statistics
No results found.
Labels
Clear labels   
blocked
Waits on the issues listed in its "Blocked by:" line before implementation

  
bug
Category: something is broken; behaviour differs from the spec or docs

  
enhancement
Category: new feature or improvement, including refactors, chores and docs

  
high-priority
Address before ordinary-priority work; independent of triage readiness and blockers

  
low-priority
Address after ordinary-priority work; independent of triage readiness and blockers

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
referenced
Previously closed issue reopened or referenced by an open issue; visible history marker

  
research
Needs investigation (internet or local resources) before it can be triaged down; used alongside a category and a triage role

  
wontfix
Will not be actioned

No labels
blocked
bug
enhancement
high-priority
low-priority
needs-info
needs-triage
ready-for-agent
ready-for-human
referenced
research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gabogg/hikcentral#253
No description provided.