gabogg/hikcentral
Watch
1
0
Fork
You've already forked hikcentral
 0
Code Issues 113 Pull requests 8 Projects Releases Packages Wiki Activity Actions

refactor(ui): clean up cancelPendingChange duplication and i18n keys in app.js #252

New issue
Open
opened 2026-10-03 09:12:06 +00:00 by gabogg · 0 comments
gabogg commented 2026-10-03 09:12:06 +00:00
Owner
Copy link

Follow-up for PR #177 (next-day settings activation, #114) addressing pass-4 review finding P3-5:

Scope

In app/static/js/app.js, cancelPendingChange is a near-duplicate of deleteHoliday and reuses confirmDeleteScheduleException and scheduleExceptionDeleted translation keys, causing the UI to report that an exception was "deleted" when the user cancels a pending change. Furthermore, its || '...' English fallbacks are dead code.

Acceptance Criteria

  • Introduce dedicated i18n keys for pending change cancellation confirmation and success.
  • Eliminate duplicate code and remove dead code English fallbacks in app.js.

Refs #177, #114.

Follow-up for PR #177 (next-day settings activation, #114) addressing pass-4 review finding P3-5: ### Scope In `app/static/js/app.js`, `cancelPendingChange` is a near-duplicate of `deleteHoliday` and reuses `confirmDeleteScheduleException` and `scheduleExceptionDeleted` translation keys, causing the UI to report that an exception was "deleted" when the user cancels a pending change. Furthermore, its `|| '...'` English fallbacks are dead code. ### Acceptance Criteria - Introduce dedicated i18n keys for pending change cancellation confirmation and success. - Eliminate duplicate code and remove dead code English fallbacks in `app.js`. Refs #177, #114.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
docs/test-policy-217
feat/historical-flow-publication
feat/historical-flow-curation
fix/holiday-stamping-followups
chore/schedule-p3-followups-186
fix/test-isolation
test/silent-camera-trace-199
feat/historical-flow-statistics
No results found.
Labels
Clear labels   
blocked
Waits on the issues listed in its "Blocked by:" line before implementation

  
bug
Category: something is broken; behaviour differs from the spec or docs

  
enhancement
Category: new feature or improvement, including refactors, chores and docs

  
high-priority
Address before ordinary-priority work; independent of triage readiness and blockers

  
low-priority
Address after ordinary-priority work; independent of triage readiness and blockers

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
referenced
Previously closed issue reopened or referenced by an open issue; visible history marker

  
research
Needs investigation (internet or local resources) before it can be triaged down; used alongside a category and a triage role

  
wontfix
Will not be actioned

No labels
blocked
bug
enhancement
high-priority
low-priority
needs-info
needs-triage
ready-for-agent
ready-for-human
referenced
research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gabogg/hikcentral#252
No description provided.