bug(schedule): saving unchanged weekly schedule form stages empty pending change #249

New issue

Open

opened 2026-10-03 09:11:42 +00:00 by gabogg · 1 comment

gabogg commented

2026-10-03 09:11:42 +00:00

Owner

Follow-up for PR #177 (next-day settings activation, #114) addressing pass-4 review finding P3-2:

Scope

Saving the weekly schedule form when no fields have changed from active values and nothing is currently pending stages an empty WEEKLY_SCHEDULE pending change (payload = {"items": []}) and returns a "Weekly schedule saved, takes effect tomorrow" notice instead of treating the form as clean/unchanged.

Acceptance Criteria

When saving the weekly schedule form with no changes against active values and no pending items, do not stage an empty pending change.
The UI / response reports no changes pending or leaves active schedule as-is.

Refs #177, #114.

Follow-up for PR #177 (next-day settings activation, #114) addressing pass-4 review finding P3-2: ### Scope Saving the weekly schedule form when no fields have changed from active values and nothing is currently pending stages an empty `WEEKLY_SCHEDULE` pending change (`payload = {"items": []}`) and returns a "Weekly schedule saved, takes effect tomorrow" notice instead of treating the form as clean/unchanged. ### Acceptance Criteria - When saving the weekly schedule form with no changes against active values and no pending items, do not stage an empty pending change. - The UI / response reports no changes pending or leaves active schedule as-is. Refs #177, #114.

gabogg added this to the Historical passenger-flow backfill milestone

2026-10-03 09:11:42 +00:00

gabogg added the

ready-for-agent

bug

labels

2026-10-03 09:11:42 +00:00

gabogg referenced this issue

2026-10-03 10:16:27 +00:00

feat(schedule): activate manual calibration and time changes next day #177

gabogg commented

2026-10-03 10:46:21 +00:00

Author

Owner

Adding scope from PR #177 review pass 5 (standards P3-C), same code path. The P2-B fix copies the whole WeeklyScheduleUpdateResult / DayScheduleItem comprehension into both branches (occupancy_service.py ~448 and ~481). The ACTIVE branch also computes an effective_date for a change that was never staged. Build the result once when fixing the empty-change case.

Adding scope from PR #177 review pass 5 (standards P3-C), same code path. The P2-B fix copies the whole `WeeklyScheduleUpdateResult` / `DayScheduleItem` comprehension into both branches (`occupancy_service.py` ~448 and ~481). The ACTIVE branch also computes an `effective_date` for a change that was never staged. Build the result once when fixing the empty-change case.

gabogg removed this from the Historical passenger-flow backfill milestone

2026-10-03 12:13:38 +00:00