test(statistics): add API and day_view frontend tests for closed: true #225

New issue

Open

opened 2026-10-03 06:54:28 +00:00 by gabogg · 0 comments

gabogg commented

2026-10-03 06:54:28 +00:00

Owner

P3 follow-up from PR #178 review pass 3 (r32 item f).

Finding

PR #178 added closed-day markers and fields to daily statistics and presenter views, but tests currently only cover open holidays or normal open days. closed: true (exceptional closure days or scheduled closed days) is not directly exercised in end-to-end API tests and day deck frontend tests.

Acceptance Criteria

Add FastAPI integration tests asserting that GET /api/statistics/daily and hourly endpoints correctly serialize is_closed: true / closed: true when a day is marked closed (either via weekday schedule or schedule exception).
Add frontend node tests in tests/frontend/test_statistics_deck_day.test.js verifying that day_view.js correctly renders closed day badges, muted/hatched styles, and zeroed/omitted metrics when is_closed: true.
All tests pass cleanly.

Refs #178, #161.

P3 follow-up from PR #178 review pass 3 (r32 item f). ### Finding PR #178 added closed-day markers and fields to daily statistics and presenter views, but tests currently only cover open holidays or normal open days. `closed: true` (exceptional closure days or scheduled closed days) is not directly exercised in end-to-end API tests and day deck frontend tests. ### Acceptance Criteria - Add FastAPI integration tests asserting that `GET /api/statistics/daily` and hourly endpoints correctly serialize `is_closed: true` / `closed: true` when a day is marked closed (either via weekday schedule or schedule exception). - Add frontend node tests in `tests/frontend/test_statistics_deck_day.test.js` verifying that `day_view.js` correctly renders closed day badges, muted/hatched styles, and zeroed/omitted metrics when `is_closed: true`. - All tests pass cleanly. Refs #178, #161.

gabogg added this to the Historical passenger-flow backfill milestone

2026-10-03 06:54:28 +00:00

gabogg added the

ready-for-agent

label

2026-10-03 06:54:28 +00:00

gabogg referenced this issue

2026-10-03 06:56:16 +00:00

feat(statistics): holiday and event context for investor analytics #178

gabogg referenced this issue

2026-10-03 06:58:30 +00:00

feat(statistics): holiday and event context for investor analytics #178