gabogg/hikcentral
Watch
1
0
Fork
You've already forked hikcentral
 0
Code Issues 113 Pull requests 8 Projects Releases Packages Wiki Activity Actions

refactor(statistics): consolidate duplicate is_closed and closed fields in hourly response #223

New issue
Open
opened 2026-10-03 06:54:01 +00:00 by gabogg · 0 comments
gabogg commented 2026-10-03 06:54:01 +00:00
Owner
Copy link

P3 follow-up from PR #178 review pass 3 (r32 item b).

Finding

PresenterHourlyResponse emits both is_closed and the new closed (app/schemas/statistics.py:100, 168), and day_view.js:703 reads both. DailyStatistics.is_closed already existed in the domain model. Having duplicate boolean fields for the same semantic property causes ambiguity in serialization and client rendering.

Acceptance Criteria

  • Consolidate is_closed and closed in PresenterHourlyResponse into a single field (is_closed).
  • Update day_view.js and any other frontend consumers to read only is_closed.
  • Update API contracts and tests to assert on the single consolidated field.
  • Ensure all backend and frontend node tests pass.

Refs #178, #161.

P3 follow-up from PR #178 review pass 3 (r32 item b). ### Finding `PresenterHourlyResponse` emits both `is_closed` and the new `closed` (`app/schemas/statistics.py:100, 168`), and `day_view.js:703` reads both. `DailyStatistics.is_closed` already existed in the domain model. Having duplicate boolean fields for the same semantic property causes ambiguity in serialization and client rendering. ### Acceptance Criteria - Consolidate `is_closed` and `closed` in `PresenterHourlyResponse` into a single field (`is_closed`). - Update `day_view.js` and any other frontend consumers to read only `is_closed`. - Update API contracts and tests to assert on the single consolidated field. - Ensure all backend and frontend node tests pass. Refs #178, #161.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feat/historical-flow-statistics
feat/historical-flow-publication
docs/test-policy-217
feat/historical-flow-curation
fix/holiday-stamping-followups
chore/schedule-p3-followups-186
fix/test-isolation
test/silent-camera-trace-199
No results found.
Labels
Clear labels   
blocked
Waits on the issues listed in its "Blocked by:" line before implementation

  
bug
Category: something is broken; behaviour differs from the spec or docs

  
enhancement
Category: new feature or improvement, including refactors, chores and docs

  
high-priority
Address before ordinary-priority work; independent of triage readiness and blockers

  
low-priority
Address after ordinary-priority work; independent of triage readiness and blockers

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
referenced
Previously closed issue reopened or referenced by an open issue; visible history marker

  
research
Needs investigation (internet or local resources) before it can be triaged down; used alongside a category and a triage role

  
wontfix
Will not be actioned

No labels
blocked
bug
enhancement
high-priority
low-priority
needs-info
needs-triage
ready-for-agent
ready-for-human
referenced
research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gabogg/hikcentral#223
No description provided.