chore(schedule): PR #177 second-pass P3 follow-ups (historical correction audit row, offset audit details, API docs) #215

New issue

Open

opened 2026-10-02 18:08:42 +00:00 by gabogg · 0 comments

gabogg commented

2026-10-02 18:08:42 +00:00

Owner

Follow-up for PR #177 (next-day settings activation, #114) addressing second-pass review findings P3-10, P3-16, and P3-18:

Scope

Historical Correction Audit Row (P3-16): Historical corrections currently write a SUBMISSION audit row only; reconcile with ADR 0007, CONTEXT.md, and #114 requirements for a distinct HISTORICAL_CORRECTION audit action in occupancy_settings_audit.
OFFSET Audit Details (P3-10):
- Replace magic default 8 in repository fallback with explicit config reference (patrol_guard_count).
- Re-introduce SQL LIMIT / optimization for trusted calibration history query to avoid full table scan in Python.
API Documentation Inventory (P3-18): docs/api/README.md:104 lists 4 mutation endpoints but leaves out holidays, schedules, and calibration trust endpoints.

Acceptance Criteria

Historical trust corrections persist an audit entry with action = 'HISTORICAL_CORRECTION' in occupancy_settings_audit.
Baseline offset logic dynamically references patrol_guard_count from configuration without hardcoding 8.
Repository calibration query incorporates query-level filtering / bounding instead of retrieving unconstrained rows for in-memory slicing.
docs/api/README.md exhaustively enumerates all settings mutation endpoints with their pending-activation behavior.

Refs #177, #114.

Follow-up for PR #177 (next-day settings activation, #114) addressing second-pass review findings P3-10, P3-16, and P3-18: ### Scope 1. **Historical Correction Audit Row (P3-16)**: Historical corrections currently write a SUBMISSION audit row only; reconcile with ADR 0007, CONTEXT.md, and #114 requirements for a distinct `HISTORICAL_CORRECTION` audit action in `occupancy_settings_audit`. 2. **OFFSET Audit Details (P3-10)**: - Replace magic default 8 in repository fallback with explicit config reference (`patrol_guard_count`). - Re-introduce SQL LIMIT / optimization for trusted calibration history query to avoid full table scan in Python. 3. **API Documentation Inventory (P3-18)**: `docs/api/README.md:104` lists 4 mutation endpoints but leaves out holidays, schedules, and calibration trust endpoints. ### Acceptance Criteria - Historical trust corrections persist an audit entry with `action = 'HISTORICAL_CORRECTION'` in `occupancy_settings_audit`. - Baseline offset logic dynamically references `patrol_guard_count` from configuration without hardcoding 8. - Repository calibration query incorporates query-level filtering / bounding instead of retrieving unconstrained rows for in-memory slicing. - `docs/api/README.md` exhaustively enumerates all settings mutation endpoints with their pending-activation behavior. Refs #177, #114.

gabogg added this to the Historical passenger-flow backfill milestone

2026-10-02 18:08:42 +00:00

gabogg added the

ready-for-agent

label

2026-10-02 18:08:42 +00:00

gabogg referenced this issue

2026-10-02 18:10:02 +00:00

feat(schedule): activate manual calibration and time changes next day #177

gabogg referenced this issue

2026-10-03 07:23:57 +00:00

feat(schedule): activate manual calibration and time changes next day #177