test(schedule): PR #177 second-pass P3 follow-ups (test gaps on reset transitions, controlled time, crash recovery) #213

New issue

Open

opened 2026-10-02 18:08:26 +00:00 by gabogg · 0 comments

gabogg commented

2026-10-02 18:08:26 +00:00

Owner

Follow-up for PR #177 (next-day settings activation, #114) addressing second-pass review finding P3-17:

Scope

Hand-built ResetSchedule: The 25h and 23h transition tests build ResetSchedule by hand rather than driving it through update_schedule_config_async and natural transition progression.
Uncontrolled Clocks: Several tests use time.time() directly rather than fixed facility-time epochs.
Untested Transition Scenarios: Add test coverage for a reset saved before today's reset, and a reset moved earlier through the real staging path.
Outage and Crash Recovery: Add comprehensive test scenarios simulating application restarts and crashes across effective boundaries.
UI Notices: Add end-to-end tests covering the bilingual pre-save confirmation text and post-save effective date/time/timezone notices.

Acceptance Criteria

Transition tests construct and test ResetSchedule via update_schedule_config_async rather than mocking internal dictionary structures.
All scheduled reset tests run against deterministic facility-time timestamps without depending on system wall-clock.
Explicit test coverage verifies advancing reset earlier and later with seamless single-transition cycles.
Automated tests verify daemon crash recovery across boundaries with exactly-once activation.
Tests verify presence and content of bilingual UI confirmation dialogs and effective notices.

Refs #177, #114.

Follow-up for PR #177 (next-day settings activation, #114) addressing second-pass review finding P3-17: ### Scope 1. **Hand-built ResetSchedule**: The 25h and 23h transition tests build ResetSchedule by hand rather than driving it through `update_schedule_config_async` and natural transition progression. 2. **Uncontrolled Clocks**: Several tests use `time.time()` directly rather than fixed facility-time epochs. 3. **Untested Transition Scenarios**: Add test coverage for a reset saved before today's reset, and a reset moved earlier through the real staging path. 4. **Outage and Crash Recovery**: Add comprehensive test scenarios simulating application restarts and crashes across effective boundaries. 5. **UI Notices**: Add end-to-end tests covering the bilingual pre-save confirmation text and post-save effective date/time/timezone notices. ### Acceptance Criteria - Transition tests construct and test `ResetSchedule` via `update_schedule_config_async` rather than mocking internal dictionary structures. - All scheduled reset tests run against deterministic facility-time timestamps without depending on system wall-clock. - Explicit test coverage verifies advancing reset earlier and later with seamless single-transition cycles. - Automated tests verify daemon crash recovery across boundaries with exactly-once activation. - Tests verify presence and content of bilingual UI confirmation dialogs and effective notices. Refs #177, #114.

gabogg added this to the Historical passenger-flow backfill milestone

2026-10-02 18:08:26 +00:00

gabogg added the

ready-for-agent

label

2026-10-02 18:08:26 +00:00

gabogg referenced this issue

2026-10-02 18:10:02 +00:00

feat(schedule): activate manual calibration and time changes next day #177

~~gabogg referenced this issue 2026-10-02 18:23:43 +00:00~~

fix(tests): keep tests inside their sandbox and cut suite time #218

gabogg referenced this issue