chore(schedule): call dated overrides schedule exceptions, not holidays #108

New issue

Closed

opened 2026-09-25 17:29:08 +00:00 by gabogg · 1 comment

gabogg commented

2026-09-25 17:29:08 +00:00

Owner

Raised in the 2026-09-25 grilling session. Naming only; not blocking the deck.

Dated schedule overrides are stored and labelled as "holidays" (occupancy_holidays), but they also serve one-off closures (emergency, renovation) and special hours. An emergency closure entered as a "holiday" reads wrong. Proposal: call them schedule exceptions in the admin UI (and possibly the API), with "holiday" as one kind. Needs a decision on scope (UI label only vs API/table rename) and on i18n keys (#73).

🤖 Generated with Claude Code

Maintainer triage — 2026-09-27

Maintainer clarification: holidays are expected and must not be excluded from statistics simply because they are holidays. The deck should expose holiday/event context. Distinguish a schedule exception (hours or closure override) from a holiday/event annotation that need not alter hours. Current glossary excludes holidays from Usual Weekday Baseline eligibility, not all period totals; decide baseline behavior explicitly in the linked holiday/event analytics issue. UI/API/persistence rename scope remains unresolved; this is not ready for implementation.

Confirmed triage resolution — 2026-09-27

This resolution supersedes the unresolved rename scope above.

Rename admin UI wording and documentation to Schedule exceptions, covering holiday hours, special hours and exceptional closures. Update the corresponding English/Spanish wording consistently, coordinating with #73.
Preserve existing API routes and storage names for compatibility; API/table renaming is outside this issue.
A holiday is a named day marker that can optionally supply special hours. A renovation or emergency closure is a schedule exception without automatically being a holiday.
Holiday identity, event annotations and analytics/learning eligibility are specified in #161; keep this issue naming-only and non-blocking for the statistics deck.

Maintainer confirmed the shared understanding and authorized publication. Specification settled: ready-for-agent.

Raised in the 2026-09-25 grilling session. Naming only; not blocking the deck. Dated schedule overrides are stored and labelled as "holidays" (`occupancy_holidays`), but they also serve one-off closures (emergency, renovation) and special hours. An emergency closure entered as a "holiday" reads wrong. Proposal: call them **schedule exceptions** in the admin UI (and possibly the API), with "holiday" as one kind. Needs a decision on scope (UI label only vs API/table rename) and on i18n keys (#73). 🤖 Generated with [Claude Code](https://claude.com/claude-code) ## Maintainer triage — 2026-09-27 Maintainer clarification: holidays are expected and must not be excluded from statistics simply because they are holidays. The deck should expose holiday/event context. Distinguish a schedule exception (hours or closure override) from a holiday/event annotation that need not alter hours. Current glossary excludes holidays from Usual Weekday Baseline eligibility, not all period totals; decide baseline behavior explicitly in the linked holiday/event analytics issue. UI/API/persistence rename scope remains unresolved; this is not ready for implementation. ## Confirmed triage resolution — 2026-09-27 This resolution supersedes the unresolved rename scope above. - Rename admin UI wording and documentation to **Schedule exceptions**, covering holiday hours, special hours and exceptional closures. Update the corresponding English/Spanish wording consistently, coordinating with #73. - Preserve existing API routes and storage names for compatibility; API/table renaming is outside this issue. - A holiday is a named day marker that can optionally supply special hours. A renovation or emergency closure is a schedule exception without automatically being a holiday. - Holiday identity, event annotations and analytics/learning eligibility are specified in #161; keep this issue naming-only and non-blocking for the statistics deck. Maintainer confirmed the shared understanding and authorized publication. Specification settled: ready-for-agent.

gabogg added the

needs-triage

label

2026-09-25 17:29:08 +00:00

gabogg referenced this issue

2026-09-25 18:16:35 +00:00

feat(schedule): each business day remembers the schedule it was measured under #113

gabogg referenced this issue

2026-09-27 16:29:42 +00:00

feat(statistics): holiday and event context for investor analytics #161

gabogg commented

2026-09-27 16:30:03 +00:00