chore(changelog): update legacy repository URLs to current Forgejo repository #21
Loading…
Reference in a new issue
No description provided.
Delete branch "chore/fix-changelog-urls"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Part of release-readiness to-do list (Task 1).
Problem
CHANGELOG.mdcontained 65 links pointing to the legacy GitHub repositorygithub.com/GGabrielDev/inventory-manager-java(for release compares, issues, and commit links). Additionally,setup-server.shreferenced the old repo in its header and systemd service definitions.Solution
CHANGELOG.mdwithhttps://git.gaboggamer.online/PCivil/inventory-system.setup-server.shdocumentation links and raw download URL to point to the current Forgejo repository.Review — PR #21 (changelog URL fix)
Straightforward change, but it doesn't fully accomplish what the title promises.
What's correct
github.com/GGabrielDev/inventory-manager-java→git.gaboggamer.online/PCivil/inventory-systemis applied consistently (65 URL hits in CHANGELOG.md).setup-server.shgot the correct Forgejo raw URL format:https://git.gaboggamer.online/PCivil/inventory-system/raw/branch/master/setup-server.sh. That one is now genuinely functional.What's still broken — the deep links won't resolve
The changelog body references issue/PR numbers and commit SHAs from the old GitHub repo:
.../issues/73,.../issues/77,.../issues/68, etc. — these numbers are the old tracker's IDs. The Forgejo repo's issue/PR numbering restarted at #1, soissues/73points at nothing (or, worse, a different issue that happens to share the number)..../commit/d1259c4and friends — those SHAs may not exist in this repo's history (different commit graph).So this is a cosmetic find-and-replace: the domain is right but the paths still point at content that doesn't exist here. If the goal is "working changelog links," those need to be regenerated against the Forgejo history, not just string-substituted.
Suggestion
Either:
This is low-risk to merge as-is (pure docs + a shell comment), but it shouldn't be counted as fully "fixing" the changelog URLs. Non-blocking.
Follow-up — after the description update
Thanks for the clarification in the PR body (the "Task 1" Problem/Solution framing). I re-checked the diff, and the code itself is unchanged (
5a3d3013f0), so my original concern still stands and is worth a concrete decision:The remaining issue (not addressed by the body change)
The body now correctly says "Zero legacy URL references remain." That's true for the host/domain, but not for the deep-link targets:
https://git.gaboggamer.online/PCivil/inventory-system/issues/73—73is the old GitHub issue number. The Forgejo repo's issue/PR numbering restarted at #1, so this resolves to nothing (or, worse, to an unrelated issue that happens to have that number here)..../commit/d1259c4— those SHAs are from the old repo's commit graph and don't exist in this repo.So the domain is fixed, but the paths still point at content that doesn't exist in Forgejo. The changelog links will 404.
My recommendation
This PR is fine to merge as a host update (it correctly changes the domain and the raw download URL). But please either:
CHANGELOG.mdagainst Forgejo's actual git history (the release-versioning work in PR #25 will produce this going forward) rather than string-substituting the old one.No code change required for option 1 — just confirm which intent this PR is serving.