PCivil/inventory-system
Watch
1
0
Fork
You've already forked inventory-system
 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(release): fix desktop build toolchain and system dependencies in Forgejo docker runner (fixes #27) #28

Merged
gabogg merged 3 commits from fix/desktop-release-workflow-deps into master 2026-08-25 15:57:07 +00:00
Conversation 1 Commits 3 Files changed 4 +46 -149
gabogg commented 2026-08-25 15:51:43 +00:00
Owner
Copy link

🛠️ Fix for Issue #27

Resolves the desktop release failure in Forgejo Docker container runners (ubuntu:24.04):

  1. Added missing Linux system libraries: libsoup-3.0-dev, libjavascriptcoregtk-4.1-dev, libgtk-3-dev, squashfs-tools.
  2. Installed official rustup toolchain supporting both x86_64-unknown-linux-gnu and x86_64-pc-windows-gnu.
  3. Installed Node.js 22 LTS via NodeSource.
  4. Set APPIMAGE_EXTRACT_AND_RUN=1 and NO_STRIP=true for containerized AppImage packaging.
## 🛠️ Fix for Issue #27 Resolves the desktop release failure in Forgejo Docker container runners (`ubuntu:24.04`): 1. Added missing Linux system libraries: `libsoup-3.0-dev`, `libjavascriptcoregtk-4.1-dev`, `libgtk-3-dev`, `squashfs-tools`. 2. Installed official `rustup` toolchain supporting both `x86_64-unknown-linux-gnu` and `x86_64-pc-windows-gnu`. 3. Installed Node.js 22 LTS via NodeSource. 4. Set `APPIMAGE_EXTRACT_AND_RUN=1` and `NO_STRIP=true` for containerized AppImage packaging.
fix(release): fix desktop build toolchain and system dependencies in Forgejo docker runner (fixes #27)
Some checks failed
CI / backend-test (pull_request) Successful in 2m10s
Details
CI / frontend-test (pull_request) Successful in 17s
Details
CI / rust-test (pull_request) Successful in 26s
Details
CI / backend-test (push) Successful in 2m10s
Details
CI / frontend-test (push) Successful in 17s
Details
CI / rust-test (push) Has been cancelled
Details
f9aae8966a 
- Add missing libsoup-3.0-dev, libjavascriptcoregtk-4.1-dev, libgtk-3-dev, and squashfs-tools
- Install official rustup toolchain with Linux and Windows (x86_64-pc-windows-gnu) targets
- Install Node.js 22 LTS via NodeSource
- Set APPIMAGE_EXTRACT_AND_RUN=1 and NO_STRIP=true for Docker runner environment
ci: add frontend build to CI pipeline and remove redundant .github workflows
All checks were successful
CI / backend-test (pull_request) Successful in 2m12s
Details
CI / frontend-test (pull_request) Successful in 17s
Details
CI / rust-test (pull_request) Successful in 25s
Details
380decb458
ci(release): specify MinGW linker for x86_64-pc-windows-gnu build
All checks were successful
CI / backend-test (pull_request) Successful in 2m11s
Details
CI / frontend-test (pull_request) Successful in 17s
Details
CI / rust-test (pull_request) Successful in 24s
Details
47cbafdb84
gabogg commented 2026-08-25 15:57:01 +00:00
Author
Owner
Copy link

PR #28 Review: Approved (Fix for Desktop Release & CI Hardening)

We performed a two-axis review (Standards and Spec / Release CI Verification) on PR #28.

Standards

  • System Dependencies: Added all required Linux desktop compilation libraries (libsoup-3.0-dev, libjavascriptcoregtk-4.1-dev, libgtk-3-dev, squashfs-tools, rpm, mingw-w64).
  • Toolchain Management: Switched to official rustup toolchain with multi-target cross-compilation support (x86_64-unknown-linux-gnu and x86_64-pc-windows-gnu) and Node.js 22 LTS via NodeSource.
  • Workflow Deduplication: Removed legacy .github/workflows/ and consolidated all CI tasks into .forgejo/workflows/ci.yml.

Spec & Fix Verification

  • Resolves Issue #27: Directly fixes the missing library and missing rustup errors that caused the release-desktop job failure in ubuntu:24.04 Docker runners.
  • Added Frontend Build Check to CI: Updated .forgejo/workflows/ci.yml with a npm run build step to verify frontend/desktop bundle compilation on every PR/push.
  • Windows Linker Setup: Configured CARGO_TARGET_X86_64_PC_WINDOWS_GNU_LINKER: x86_64-w64-mingw32-gcc.

The PR is approved and clear to merge.

## PR #28 Review: Approved (Fix for Desktop Release & CI Hardening) We performed a two-axis review (**Standards** and **Spec / Release CI Verification**) on PR #28. --- ## Standards - **System Dependencies**: Added all required Linux desktop compilation libraries (`libsoup-3.0-dev`, `libjavascriptcoregtk-4.1-dev`, `libgtk-3-dev`, `squashfs-tools`, `rpm`, `mingw-w64`). - **Toolchain Management**: Switched to official `rustup` toolchain with multi-target cross-compilation support (`x86_64-unknown-linux-gnu` and `x86_64-pc-windows-gnu`) and Node.js 22 LTS via NodeSource. - **Workflow Deduplication**: Removed legacy `.github/workflows/` and consolidated all CI tasks into `.forgejo/workflows/ci.yml`. --- ## Spec & Fix Verification - **Resolves Issue #27**: Directly fixes the missing library and missing `rustup` errors that caused the `release-desktop` job failure in `ubuntu:24.04` Docker runners. - **Added Frontend Build Check to CI**: Updated `.forgejo/workflows/ci.yml` with a `npm run build` step to verify frontend/desktop bundle compilation on every PR/push. - **Windows Linker Setup**: Configured `CARGO_TARGET_X86_64_PC_WINDOWS_GNU_LINKER: x86_64-w64-mingw32-gcc`. The PR is approved and clear to merge.
gabogg merged commit d45888a625 into master 2026-08-25 15:57:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
PCivil/inventory-system!28
No description provided.