follow-up(statistics): P3 cleanups from #92 review (period KPIs and entrances)

gabogg commented

2026-09-25 12:14:46 +00:00

Owner

Follow-ups from the pass-2 review of #92 (comment on #92). All P3; no P1/P2 remained. The partial-period design question is split out into its own needs-triage issue.

Standards

One trusted-multiplier helper. The daily series (bounds.end, is not None) and get_calibration_audit (bounds.next_start, truthiness) now select the cycle multiplier differently; a trusted 0.0 is accepted by one and not the other. Extract _trusted_cycle_multiplier(day, bounds, default).
Dayparts dwell multiplier. get_dwell_dayparts_async uses active_exit_multiplier while the daily series uses the cycle's trusted multiplier, so one day can show two dwell values.
Comparison logic in three places. The partial-period / zero-reference rule lives in statistics_visitor_comparison_async and twice inline in the entrances route. One compare_visitors(current, reference, partial) factory.
Previous-month quality queried twice in get_statistics_summary_async.
previous_month_daily_average_reason: str | None should use ComparisonReason.
Optional narrowing. year_quality is PeriodQuality | None but read as .partial without narrowing.
Repeated switches on granularity inside get_statistics_summary_async.
Controller try/except duplicated (ValueError → 422, LookupError → 404) across both routes.
Names. busiest_day/best_day hold the same value; old/prior/top in the entrances loop; EntranceStatistics.zone_name conflicts with CONTEXT.md's "Zone" avoid-list.

Spec

Test gaps. Untested: NO_REFERENCE_DATA; period dwell weighted by open_window_visitors; PARTIAL_PERIOD on the entrances route; skipping zero-event cameras; the < end_epoch bound on is_new.
Unaligned-week test uses a future date, so its 422 doesn't isolate the alignment check. Use a past Tuesday.

🤖 Generated with Claude Code

Follow-ups from the pass-2 review of #92 (comment on #92). All P3; no P1/P2 remained. The partial-period design question is split out into its own `needs-triage` issue. ## Standards - [ ] **One trusted-multiplier helper.** The daily series (`bounds.end`, `is not None`) and `get_calibration_audit` (`bounds.next_start`, truthiness) now select the cycle multiplier differently; a trusted `0.0` is accepted by one and not the other. Extract `_trusted_cycle_multiplier(day, bounds, default)`. - [ ] **Dayparts dwell multiplier.** `get_dwell_dayparts_async` uses `active_exit_multiplier` while the daily series uses the cycle's trusted multiplier, so one day can show two dwell values. - [ ] **Comparison logic in three places.** The partial-period / zero-reference rule lives in `statistics_visitor_comparison_async` and twice inline in the entrances route. One `compare_visitors(current, reference, partial)` factory. - [ ] **Previous-month quality queried twice** in `get_statistics_summary_async`. - [ ] **`previous_month_daily_average_reason: str | None`** should use `ComparisonReason`. - [ ] **Optional narrowing.** `year_quality` is `PeriodQuality | None` but read as `.partial` without narrowing. - [ ] **Repeated switches on `granularity`** inside `get_statistics_summary_async`. - [ ] **Controller try/except duplicated** (`ValueError → 422`, `LookupError → 404`) across both routes. - [ ] **Names.** `busiest_day`/`best_day` hold the same value; `old`/`prior`/`top` in the entrances loop; `EntranceStatistics.zone_name` conflicts with CONTEXT.md's "Zone" avoid-list. ## Spec - [ ] **Test gaps.** Untested: `NO_REFERENCE_DATA`; period dwell weighted by `open_window_visitors`; `PARTIAL_PERIOD` on the entrances route; skipping zero-event cameras; the `< end_epoch` bound on `is_new`. - [ ] **Unaligned-week test** uses a future date, so its 422 doesn't isolate the alignment check. Use a past Tuesday. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

gabogg added the

ready-for-agent

label

2026-09-25 12:14:46 +00:00

gabogg referenced this issue from a commit

2026-09-25 12:17:30 +00:00

feat(statistics): period KPIs and entrance comparisons (#83, #86) (#92)

gabogg referenced this issue

2026-09-25 17:29:06 +00:00

fix(statistics): daypart dwell multiplier, usual daypart labels, per-day excluded flag #106

gabogg commented

2026-09-25 17:29:12 +00:00

Author

Owner

The daypart dwell multiplier and the trusted-multiplier helper moved to #106. The rest stays here.

🤖 Generated with Claude Code

The daypart dwell multiplier and the trusted-multiplier helper moved to #106. The rest stays here. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

gabogg referenced this issue

2026-09-25 23:43:46 +00:00

fix(statistics): daypart dwell multiplier, usual daypart labels, per-day excluded flag (#106) #126

gabogg referenced this issue

2026-09-26 01:41:03 +00:00

fix(statistics): daypart dwell multiplier, usual daypart labels, per-day excluded flag (#106) #126

gabogg referenced this issue from a commit

2026-09-26 10:25:34 +00:00

refactor(statistics): resolve review follow-ups across statistics domain

gabogg referenced this issue

2026-09-26 10:25:45 +00:00

refactor(statistics): resolve review follow-ups across statistics domain #132