docs(domain): measurements bar delta also contains SENSORLESS_JUMPERED doors, not only excluded ones #40

Open
opened 2026-09-21 18:18:31 +00:00 by gabogg · 1 comment
Owner

Context

Follow-up from the code review of #37 (comment #issuecomment-882). Non-blocking; #37 merged with this known.

CONTEXT.md now documents the 5-measurement bar as an inequality rather than a closed-sum identity:

Measurements Bar Sub-Counters: [...] the 5 cells do not form a closed-sum mathematical identity when excluded doors exist in the facility inventory: total_doors >= openVerified + closedVerified + sensorlessOpen + offline, where the delta represents quarantined/excluded doors.

The inequality itself is correct and was verified against the bucket logic in app/services/door_service.py:1229-1246. The characterisation of the delta is not complete.

Problem

The SIN SENSOR cell is populated from sensorless_open_count only:

sensorlessOpen: overview.sensorless_open_count ?? overview.total_sensorless_count,

app/static/js/src/telemetry/telemetry_engine.js:669

Backend-side, sensorless_open_count=len(sensorless_open_doors) and sensorless_jumpered_doors is a separate bucket (door_service.py:1241-1242, :1279-1281). So a SENSORLESS_JUMPERED door is counted in total_doors but appears in none of the four sub-cells, landing in the delta alongside genuinely excluded doors.

The delta is therefore excluded non-offline doors + sensorless-jumpered doors, not "quarantined/excluded doors".

Options

  1. Document it accurately — amend the CONTEXT.md line to name both contributors to the delta.
  2. Surface jumpered doors in the bar — either fold them into SIN SENSOR (use total_sensorless_count) or give them their own cell. SENSORLESS_JUMPERED is the hazard category, so silently omitting it from the operator's headline counters is arguably the bigger issue.

Option 2 is a UI decision; option 1 is a one-line docs fix and should happen regardless.

Acceptance criteria

  • CONTEXT.md describes the delta accurately, naming every category that falls outside the four sub-cells.
  • A decision is recorded on whether SENSORLESS_JUMPERED doors should be visible in the measurements bar.
## Context Follow-up from the code review of #37 (comment [#issuecomment-882](https://git.gaboggamer.online/gabogg/hikcentral/pulls/37#issuecomment-882)). Non-blocking; #37 merged with this known. `CONTEXT.md` now documents the 5-measurement bar as an inequality rather than a closed-sum identity: > **Measurements Bar Sub-Counters**: [...] the 5 cells do not form a closed-sum mathematical identity when excluded doors exist in the facility inventory: `total_doors >= openVerified + closedVerified + sensorlessOpen + offline`, where the delta represents quarantined/excluded doors. The inequality itself is correct and was verified against the bucket logic in `app/services/door_service.py:1229-1246`. The characterisation of the delta is not complete. ## Problem The `SIN SENSOR` cell is populated from `sensorless_open_count` only: ```js sensorlessOpen: overview.sensorless_open_count ?? overview.total_sensorless_count, ``` `app/static/js/src/telemetry/telemetry_engine.js:669` Backend-side, `sensorless_open_count=len(sensorless_open_doors)` and `sensorless_jumpered_doors` is a separate bucket (`door_service.py:1241-1242`, `:1279-1281`). So a `SENSORLESS_JUMPERED` door is counted in `total_doors` but appears in none of the four sub-cells, landing in the delta alongside genuinely excluded doors. The delta is therefore *excluded non-offline doors + sensorless-jumpered doors*, not "quarantined/excluded doors". ## Options 1. Document it accurately — amend the `CONTEXT.md` line to name both contributors to the delta. 2. Surface jumpered doors in the bar — either fold them into `SIN SENSOR` (use `total_sensorless_count`) or give them their own cell. `SENSORLESS_JUMPERED` is the hazard category, so silently omitting it from the operator's headline counters is arguably the bigger issue. Option 2 is a UI decision; option 1 is a one-line docs fix and should happen regardless. ## Acceptance criteria - [ ] `CONTEXT.md` describes the delta accurately, naming every category that falls outside the four sub-cells. - [ ] A decision is recorded on whether `SENSORLESS_JUMPERED` doors should be visible in the measurements bar.
Author
Owner

Folded into PR #45 — its CONTEXT.md §2 (measurements-bar semantics) update will describe the delta as excluded doors plus SENSORLESS_JUMPERED doors, which sit outside all four sub-cells. Re-tagged ready-for-agent; kept open so it is tracked until #45 lands (add Closes #40 to #45 when convenient).

Folded into PR #45 — its CONTEXT.md §2 (measurements-bar semantics) update will describe the delta as excluded doors **plus** `SENSORLESS_JUMPERED` doors, which sit outside all four sub-cells. Re-tagged `ready-for-agent`; kept open so it is tracked until #45 lands (add `Closes #40` to #45 when convenient).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gabogg/hikcentral#40
No description provided.