docs(domain): measurements bar delta also contains SENSORLESS_JUMPERED doors, not only excluded ones #40
Labels
No labels
blocked
bug
enhancement
high-priority
low-priority
needs-info
needs-triage
ready-for-agent
ready-for-human
referenced
research
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gabogg/hikcentral#40
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Follow-up from the code review of #37 (comment #issuecomment-882). Non-blocking; #37 merged with this known.
CONTEXT.mdnow documents the 5-measurement bar as an inequality rather than a closed-sum identity:The inequality itself is correct and was verified against the bucket logic in
app/services/door_service.py:1229-1246. The characterisation of the delta is not complete.Problem
The
SIN SENSORcell is populated fromsensorless_open_countonly:app/static/js/src/telemetry/telemetry_engine.js:669Backend-side,
sensorless_open_count=len(sensorless_open_doors)andsensorless_jumpered_doorsis a separate bucket (door_service.py:1241-1242,:1279-1281). So aSENSORLESS_JUMPEREDdoor is counted intotal_doorsbut appears in none of the four sub-cells, landing in the delta alongside genuinely excluded doors.The delta is therefore excluded non-offline doors + sensorless-jumpered doors, not "quarantined/excluded doors".
Options
CONTEXT.mdline to name both contributors to the delta.SIN SENSOR(usetotal_sensorless_count) or give them their own cell.SENSORLESS_JUMPEREDis the hazard category, so silently omitting it from the operator's headline counters is arguably the bigger issue.Option 2 is a UI decision; option 1 is a one-line docs fix and should happen regardless.
Acceptance criteria
CONTEXT.mddescribes the delta accurately, naming every category that falls outside the four sub-cells.SENSORLESS_JUMPEREDdoors should be visible in the measurements bar.Folded into PR #45 — its CONTEXT.md §2 (measurements-bar semantics) update will describe the delta as excluded doors plus
SENSORLESS_JUMPEREDdoors, which sit outside all four sub-cells. Re-taggedready-for-agent; kept open so it is tracked until #45 lands (addCloses #40to #45 when convenient).