chore(schedule): activation daemon error logging with exc_info and documentation standards #232

New issue

Open

opened 2026-10-03 07:23:33 +00:00 by gabogg · 0 comments

gabogg commented

2026-10-03 07:23:33 +00:00

Owner

Follow-up for PR #177 (next-day settings activation, #114) addressing pass-3 review findings P3-J and P3-Q:

Scope

Activation Daemon Logging & Backoff (P3-J): In activate_due_pending_changes_async, the activation catch-all logs with an f-string without exc_info=True. A permanently failing pending change causes error log spam on every background tick and request. Log with proper exception tracebacks (logger.exception / exc_info=True) and structured context.
Architecture and Agent Docs (P3-Q): Update docs/agents/ and docs/standards/ to reflect next-day activation architectural patterns, effective reset schedules (occupancy_effective_resets), and pending settings staging conventions introduced in #114 and ADR 0007.

Acceptance Criteria

Uncaught exceptions during pending change activation log the full traceback via logger.exception with change ID and payload context.
docs/agents/ and docs/standards/ reflect the next-day settings activation architecture, contiguous cycle transitions, and staging patterns.

Refs #177, #114.

Follow-up for PR #177 (next-day settings activation, #114) addressing pass-3 review findings P3-J and P3-Q: ### Scope 1. **Activation Daemon Logging & Backoff (P3-J)**: In `activate_due_pending_changes_async`, the activation catch-all logs with an f-string without `exc_info=True`. A permanently failing pending change causes error log spam on every background tick and request. Log with proper exception tracebacks (`logger.exception` / `exc_info=True`) and structured context. 2. **Architecture and Agent Docs (P3-Q)**: Update `docs/agents/` and `docs/standards/` to reflect next-day activation architectural patterns, effective reset schedules (`occupancy_effective_resets`), and pending settings staging conventions introduced in #114 and ADR 0007. ### Acceptance Criteria - Uncaught exceptions during pending change activation log the full traceback via `logger.exception` with change ID and payload context. - `docs/agents/` and `docs/standards/` reflect the next-day settings activation architecture, contiguous cycle transitions, and staging patterns. Refs #177, #114.

gabogg added the

ready-for-agent

label

2026-10-03 07:23:33 +00:00

gabogg referenced this issue

2026-10-03 07:23:57 +00:00

feat(schedule): activate manual calibration and time changes next day #177

gabogg referenced this issue

2026-10-03 07:24:32 +00:00

feat(schedule): activate manual calibration and time changes next day #177