feat(ui): PR #178 second-pass P3 follow-ups (admin event editor, localization, and telemetry tokens) #212

New issue

Open

opened 2026-10-02 17:59:07 +00:00 by gabogg · 0 comments

gabogg commented

2026-10-02 17:59:07 +00:00

Owner

These P3 findings from the second review pass on #178 (holiday and event context for investor analytics, #161) were deferred. None of them blocked the merge.

Standards

Admin UI "completed day" check uses browser UTC date (app.js:2566, toISOString()).
- Finding: It checks against browser UTC date rather than facility business day. With a positive UTC offset the prompt is skipped, and the server returns 422.
- Acceptance: use the facility business day calculation in the frontend before determining whether a date is completed.
Admin UI localization and timezone badge.
- Finding: New admin UI strings are English-only (EVENTS, HOLIDAY/NON-HOLIDAY, MAKE HOLIDAY, prompt/alert text, TZ:). index.html:759 has no data-i18n. The timezone badge is hardcoded to UTC-04:00 and changes only when an event exists.
- Acceptance: add data-i18n attributes and ES/EN dictionary entries for all admin event/holiday strings, and display the configured facility timezone dynamically.
Admin holiday badge and toggle color tokens.
- Finding: The admin holiday badge and toggle use amber styling, which ui-design-guidelines §2.1 reserves for cautionary telemetry.
- Acceptance: replace amber styling with neutral/accent tokens in compliance with ui-design-guidelines.

Spec

Admin UI event editing capability.
- Finding: Admin UI only supports creating and deleting events; there is no UI modal or workflow for editing existing events.
- Acceptance: provide an edit modal/button for updating event name, description, and date/time range.

Refs #178, #161.

These P3 findings from the second review pass on #178 (holiday and event context for investor analytics, #161) were deferred. None of them blocked the merge. ### Standards 1. **Admin UI "completed day" check uses browser UTC date** (`app.js:2566`, `toISOString()`). - Finding: It checks against browser UTC date rather than facility business day. With a positive UTC offset the prompt is skipped, and the server returns 422. - Acceptance: use the facility business day calculation in the frontend before determining whether a date is completed. 2. **Admin UI localization and timezone badge**. - Finding: New admin UI strings are English-only (`EVENTS`, `HOLIDAY`/`NON-HOLIDAY`, `MAKE HOLIDAY`, prompt/alert text, `TZ:`). `index.html:759` has no `data-i18n`. The timezone badge is hardcoded to `UTC-04:00` and changes only when an event exists. - Acceptance: add `data-i18n` attributes and ES/EN dictionary entries for all admin event/holiday strings, and display the configured facility timezone dynamically. 3. **Admin holiday badge and toggle color tokens**. - Finding: The admin holiday badge and toggle use amber styling, which ui-design-guidelines §2.1 reserves for cautionary telemetry. - Acceptance: replace amber styling with neutral/accent tokens in compliance with ui-design-guidelines. ### Spec 4. **Admin UI event editing capability**. - Finding: Admin UI only supports creating and deleting events; there is no UI modal or workflow for editing existing events. - Acceptance: provide an edit modal/button for updating event name, description, and date/time range. Refs #178, #161.

gabogg added the

ready-for-agent

label

2026-10-02 17:59:07 +00:00

gabogg referenced this issue

2026-10-02 18:04:26 +00:00

feat(statistics): holiday and event context for investor analytics #178

~~gabogg referenced this issue 2026-10-02 18:17:11 +00:00~~

fix(tests): two tests reach real HikCentral endpoints and wait out network timeouts (45 s per run) #216

gabogg referenced this issue

2026-10-03 06:56:16 +00:00

feat(statistics): holiday and event context for investor analytics #178