refactor(statistics-deck): consolidate the period views' shared helpers into the shell #156

New issue

Open

opened 2026-09-27 10:02:13 +00:00 by gabogg · 0 comments

gabogg commented

2026-09-27 10:02:13 +00:00

Owner

Scope

View kit module (e.g. statistics_deck/views/kit.js), extracted from the three view files:
- KPI tile rendering;
- comparison text ("—" plus reason, basis/DAILY_AVERAGE tag);
- number, percent and count formatting via ctx.locale (memoised Intl.NumberFormat);
- the entrance-share graph and list;
- the tier→glyph/style maps;
- per-cell error/loading states.
One set of statisticsDeck.comparison.reason.* texts. The views arrived with three different wordings; the Month wording is canonical, applied at merge.
withData scope. Document it as whole counts only, and add a helper that renders one <data value={raw}>formatted</data> for formatted figures (decimals, thousands separators, percentages). This came from the #149 second-pass review, S2-1. Week's numberParts folds into it.
deckChartOptions: deep-merge scales.*.ticks, so views stop re-spreading defaults (#149 S2-3).
Shared hatch. One hatch custom property/class used by the CSS swatches and the view CSS; no literal rgba() anywhere.

Acceptance

No behaviour change. All three views' frontend tests keep passing, adjusted only for imports.
The duplicated helpers are gone from the view files.

The Day, Week and Month views (#134–#136; PRs #149, #148, #147) were built in parallel. On purpose, each keeps its shared-looking helpers local until all three are merged. This issue consolidates them into the shell. ## Scope - [ ] **View kit module** (e.g. `statistics_deck/views/kit.js`), extracted from the three view files: - KPI tile rendering; - comparison text ("—" plus reason, basis/`DAILY_AVERAGE` tag); - number, percent and count formatting via `ctx.locale` (memoised `Intl.NumberFormat`); - the entrance-share graph and list; - the tier→glyph/style maps; - per-cell error/loading states. - [ ] **One set of `statisticsDeck.comparison.reason.*` texts.** The views arrived with three different wordings; the Month wording is canonical, applied at merge. - [ ] **`withData` scope.** Document it as whole counts only, and add a helper that renders one `<data value={raw}>formatted</data>` for formatted figures (decimals, thousands separators, percentages). This came from the #149 second-pass review, S2-1. Week's `numberParts` folds into it. - [ ] **`deckChartOptions`**: deep-merge `scales.*.ticks`, so views stop re-spreading defaults (#149 S2-3). - [ ] **Shared hatch.** One hatch custom property/class used by the CSS swatches and the view CSS; no literal `rgba()` anywhere. ## Acceptance - No behaviour change. All three views' frontend tests keep passing, adjusted only for imports. - The duplicated helpers are gone from the view files.

gabogg added the

ready-for-agent

label

2026-09-27 10:02:13 +00:00

gabogg referenced this issue

2026-09-27 15:24:23 +00:00

perf(statistics): deck routes take 2–30 s on real data (P1) #157

gabogg referenced this issue

2026-09-27 15:24:27 +00:00

fix(statistics-deck): KPI typography, reason casing and 760 px heatmap labels differ across views #159