refactor(ui): follow-up P3 findings from PR #146 calibration config tab #151

New issue

Open

opened 2026-09-26 23:29:48 +00:00 by gabogg · 0 comments

gabogg commented

2026-09-26 23:29:48 +00:00

Owner

Context & Findings

Relocate or Retire Raw Telemetry Tables & Exporters
- With analytics removed from ROLE_ALLOWED_DECKS.admin and its button hidden in PR #146, the raw telemetry data tables (Passenger Flow, Door Access Sessions, Hardware Transitions) and the CSV/JSON exporter inside #content-analytics are no longer reachable via the UI.
- Decision needed: Decide whether to relocate these tables into System Diagnostics (#content-probes), incorporate them into the Statistics Deck (#133 / #144), or retire them along with their backend routes.
Verification Gap in test_static_assets.py
- Add calib-confidence-margin-badge to dynamic_metric_ids in test_dom_invariants_zero_radius_and_tabular_nums to guarantee continuous test enforcement of the tabular-nums invariant.
Consolidate Multiplier DOM Binding in Workbench & Equation Card
- calib-active-multiplier and calib-workbench-active-multiplier are currently updated via tandem DOM writes in app/static/js/app.js. Consolidate these via a unified helper or shared class selector.
DOM Cleanup for #deck-btn-analytics
- #deck-btn-analytics is currently retained in index.html with class hidden. Consider completely removing it from the DOM once all legacy references and tests are fully decoupled.
Document Navigation Button Label [ F3: CONFIGURATION ]
- Document the rename of #deck-btn-occupancy-admin from CALIBRATION_LAB to CONFIGURATION across architecture docs and keymaps.

Refs #130, #146.

Follow-up tracking issue for P3 review findings identified during the second-round code review of PR #146 (moving calibration tools to configuration tab and swapping admin analytics to the statistics deck, resolving #130). ### Context & Findings 1. **Relocate or Retire Raw Telemetry Tables & Exporters** - With `analytics` removed from `ROLE_ALLOWED_DECKS.admin` and its button hidden in PR #146, the raw telemetry data tables (Passenger Flow, Door Access Sessions, Hardware Transitions) and the CSV/JSON exporter inside `#content-analytics` are no longer reachable via the UI. - *Decision needed*: Decide whether to relocate these tables into System Diagnostics (`#content-probes`), incorporate them into the Statistics Deck (#133 / #144), or retire them along with their backend routes. 2. **Verification Gap in `test_static_assets.py`** - Add `calib-confidence-margin-badge` to `dynamic_metric_ids` in `test_dom_invariants_zero_radius_and_tabular_nums` to guarantee continuous test enforcement of the tabular-nums invariant. 3. **Consolidate Multiplier DOM Binding in Workbench & Equation Card** - `calib-active-multiplier` and `calib-workbench-active-multiplier` are currently updated via tandem DOM writes in `app/static/js/app.js`. Consolidate these via a unified helper or shared class selector. 4. **DOM Cleanup for `#deck-btn-analytics`** - `#deck-btn-analytics` is currently retained in `index.html` with class `hidden`. Consider completely removing it from the DOM once all legacy references and tests are fully decoupled. 5. **Document Navigation Button Label `[ F3: CONFIGURATION ]`** - Document the rename of `#deck-btn-occupancy-admin` from `CALIBRATION_LAB` to `CONFIGURATION` across architecture docs and keymaps. Refs #130, #146.

gabogg added the

ready-for-agent

label

2026-09-26 23:29:48 +00:00

gabogg referenced this issue

2026-09-26 23:29:53 +00:00

feat(ui): move calibration tools into a Calibration section of the configuration tab (#130) #146