chore(analytics): retire routes that only fed the dropped analytics charts #131

Open
opened 2026-09-26 10:04:53 +00:00 by gabogg · 1 comment
Owner

Blocked by: the statistics deck replacing the admin analytics tab (#80 deck UI work).

Decided with the maintainer on 2026-09-25 (recorded on #80): the three operational charts on the admin analytics tab are dropped, not moved, because the statistics deck covers their content:

  • flow curves and net flow;
  • estimated occupancy with its confidence margin;
  • the multi-day comparison.

Once the deck ships and those charts are removed, retire any route that only fed them.

Candidates (check callers first)

  • GET /api/analytics/timeseries/multiday: only caller today is the multi-day comparison in app.js.
  • GET /api/analytics/timeseries/hourly: fed the flow and occupancy charts. The statistics hourly route may share its service function, so retire the route, not the shared service code.
  • GET /api/analytics/dwell/dayparts: check whether anything besides the old analytics tab uses it; the statistics dayparts route is the deck's.

For each, before removing: search the frontend, CLI, scripts and docs for callers; remove the route, its schema-only types, its tests and its entry in docs/api/README.md; keep shared service code that the statistics routes use. scripts/check_docs.py must pass with the new operation count.

Refs #80.

🤖 Generated with Claude Code

Blocked by: the statistics deck replacing the admin `analytics` tab (#80 deck UI work). Decided with the maintainer on 2026-09-25 (recorded on #80): the three operational charts on the admin `analytics` tab are dropped, not moved, because the statistics deck covers their content: - flow curves and net flow; - estimated occupancy with its confidence margin; - the multi-day comparison. Once the deck ships and those charts are removed, retire any route that only fed them. ## Candidates (check callers first) - `GET /api/analytics/timeseries/multiday`: only caller today is the multi-day comparison in `app.js`. - `GET /api/analytics/timeseries/hourly`: fed the flow and occupancy charts. The statistics hourly route may share its service function, so retire the route, not the shared service code. - `GET /api/analytics/dwell/dayparts`: check whether anything besides the old analytics tab uses it; the statistics dayparts route is the deck's. For each, before removing: search the frontend, CLI, scripts and docs for callers; remove the route, its schema-only types, its tests and its entry in `docs/api/README.md`; keep shared service code that the statistics routes use. `scripts/check_docs.py` must pass with the new operation count. Refs #80. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Author
Owner

Maintainer requested removal of the blocked label. The statistics deck is present, but current app/static/js/app.js still calls /api/analytics/timeseries/hourly and /api/analytics/timeseries/multiday. Remove or replace the old chart callers before deleting their routes, and retain shared statistics service code. The existing caller-check acceptance criteria remain in force; removing this label does not establish that the old charts have already been removed.

Maintainer requested removal of the blocked label. The statistics deck is present, but current app/static/js/app.js still calls /api/analytics/timeseries/hourly and /api/analytics/timeseries/multiday. Remove or replace the old chart callers before deleting their routes, and retain shared statistics service code. The existing caller-check acceptance criteria remain in force; removing this label does not establish that the old charts have already been removed.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gabogg/hikcentral#131
No description provided.