feat(statistics): Closed Days are not business days #103

New issue

Closed

opened 2026-09-25 17:29:03 +00:00 by gabogg · 0 comments

gabogg commented

2026-09-25 17:29:03 +00:00

Owner

Step 1 of the pre-deck work agreed on 2026-09-25 (grilling session after the #89–#94 merges). Decisions below are settled.

Problem

The facility can already declare a closed day: a weekday unchecked in the weekly schedule (occupancy_daily_schedule.is_open = 0) or a dated entry marked closed (occupancy_holidays.is_open = 0). Statistics ignore it. A closed day with no counted data makes its week/month a Partial Period exactly like an outage, and a closed day with staff passages is counted as a normal business day.

Decisions

New glossary term Closed Day: a business day on which the facility's schedule declares it closed to the public, through its weekday schedule or a dated exception. It is not a business day for statistics. Avoid: holiday (a holiday may be open with its own hours), outage (missing data on an open day).
A Closed Day is excluded from business_days, so it never makes a period partial and never lowers the daily average.
Its counted passages (guards, staff) stay stored and visible in operations views, but do not enter statistics figures: period visitors/egress, daily average, busiest/best day, highest peak, weekend share, entrance totals and shares.
It is never a Usual Weekday Baseline sample.
Selecting a Closed Day directly: the summary returns a closed status instead of KPIs (no 404/422 surprise for the deck).
Picker quality and daily rows expose it: closed_days on PeriodQuality, is_closed on DailyStatistics.
Comparisons keep comparing totals; the badge explains fewer business days.
Closure resolution uses the same precedence as the live schedule: a dated entry overrides the weekday schedule.

Out of scope

Calibration treatment of Closed Days (separate follow-up).
Renaming "holidays" to "schedule exceptions" in the admin (separate follow-up).

🤖 Generated with Claude Code

Step 1 of the pre-deck work agreed on 2026-09-25 (grilling session after the #89–#94 merges). Decisions below are settled. ## Problem The facility can already declare a closed day: a weekday unchecked in the weekly schedule (`occupancy_daily_schedule.is_open = 0`) or a dated entry marked closed (`occupancy_holidays.is_open = 0`). Statistics ignore it. A closed day with no counted data makes its week/month a **Partial Period** exactly like an outage, and a closed day with staff passages is counted as a normal business day. ## Decisions - New glossary term **Closed Day**: a business day on which the facility's schedule declares it closed to the public, through its weekday schedule or a dated exception. It is not a business day for statistics. _Avoid_: holiday (a holiday may be open with its own hours), outage (missing data on an open day). - A Closed Day is excluded from `business_days`, so it never makes a period partial and never lowers the daily average. - Its counted passages (guards, staff) stay stored and visible in operations views, but do not enter statistics figures: period visitors/egress, daily average, busiest/best day, highest peak, weekend share, entrance totals and shares. - It is never a Usual Weekday Baseline sample. - Selecting a Closed Day directly: the summary returns a closed status instead of KPIs (no 404/422 surprise for the deck). - Picker quality and daily rows expose it: `closed_days` on `PeriodQuality`, `is_closed` on `DailyStatistics`. - Comparisons keep comparing totals; the badge explains fewer business days. - Closure resolution uses the same precedence as the live schedule: a dated entry overrides the weekday schedule. ## Out of scope - Calibration treatment of Closed Days (separate follow-up). - Renaming "holidays" to "schedule exceptions" in the admin (separate follow-up). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

gabogg added the

ready-for-agent

label

2026-09-25 17:29:03 +00:00

gabogg referenced this issue

2026-09-25 17:29:09 +00:00

statistics: should scheduled closures make a period partial and suppress comparisons? #100

gabogg referenced this issue from a commit

2026-09-25 17:38:06 +00:00

feat(statistics): Closed Days are not business days

gabogg referenced this issue from a pull request that will close it,

2026-09-25 17:38:23 +00:00