Orphaned routes: /general and the 24 /[slug]-[style]-[mode] pages have no entry point #7

New issue

Open

opened 2026-09-19 17:31:31 +00:00 by gabogg · 0 comments

gabogg commented

2026-09-19 17:31:31 +00:00

Owner

The route inventory (docs/routes.md) makes reachability visible. Verified against the href builders in src/ and against the built output in dist/:

Reachable: /, the two topic menus, their 12 [topic] children, and the 8 /[slug]-[mode] routes (linked from /general at general.astro:80-83).
Orphaned (no entry point from outside):
- /general itself — nothing links to it, though it in turn links the 8 /[slug]-[mode] routes.
- The 24 /[slug]-[style]-[mode] routes — no page outside that set links into it. hrefs to [style] routes do exist, but only inside the set: the mode switch (BrochurePage.astro:36-37) and the style switch (StyleSwitch.astro:24), the latter rendered only when process.env.VERCEL_ENV === 'preview' (BrochurePage.astro:33), so the style matrix is preview-only. The school brochures open as in-page <dialog> modals instead.

That is 25 orphaned pages (1 + 24), plus the 8 /[slug]-[mode] reachable only through the orphaned /general.

Decision needed (triage): for each orphaned surface, either link it or delete the page and its data. For the 24, the decision also covers the preview-only style switch: promote it to production, or drop the style matrix. Product/site decision, deferred (the site should not change until reviewed).

Scope note: the home page and the two topic menus (and their [topic] children) are frozen legacy routes pinned by deployed QR codes (ADR-0002) and must not be changed or deleted.

Surfaced by the code review of PR #6. Round 2 corrected an earlier reachability error; round 3 corrected the supporting rationale (a grep for literal style ids misses template literals).

The route inventory (`docs/routes.md`) makes reachability visible. Verified against the `href` builders in `src/` and against the built output in `dist/`: - **Reachable:** `/`, the two topic menus, their 12 `[topic]` children, and the 8 `/[slug]-[mode]` routes (linked from `/general` at `general.astro:80-83`). - **Orphaned (no entry point from outside):** - `/general` itself — nothing links to it, though it in turn links the 8 `/[slug]-[mode]` routes. - The **24** `/[slug]-[style]-[mode]` routes — no page outside that set links into it. `href`s to `[style]` routes do exist, but only inside the set: the mode switch (`BrochurePage.astro:36-37`) and the style switch (`StyleSwitch.astro:24`), the latter rendered only when `process.env.VERCEL_ENV === 'preview'` (`BrochurePage.astro:33`), so the style matrix is preview-only. The school brochures open as in-page `<dialog>` modals instead. That is **25 orphaned pages** (1 + 24), plus the 8 `/[slug]-[mode]` reachable only through the orphaned `/general`. **Decision needed (triage):** for each orphaned surface, either link it or delete the page and its data. For the 24, the decision also covers the preview-only style switch: promote it to production, or drop the style matrix. Product/site decision, deferred (the site should not change until reviewed). **Scope note:** the home page and the two topic menus (and their `[topic]` children) are **frozen legacy routes** pinned by deployed QR codes (ADR-0002) and must not be changed or deleted. Surfaced by the code review of PR #6. Round 2 corrected an earlier reachability error; round 3 corrected the supporting rationale (a grep for literal style ids misses template literals).

gabogg added the

needs-triage

label

2026-09-19 17:31:31 +00:00

gabogg referenced this issue

2026-09-19 17:36:03 +00:00

docs: standardize repo docs and scaffold agentic-coding config #6

gabogg referenced this issue

2026-09-19 17:36:04 +00:00

docs: standardize repo docs and scaffold agentic-coding config #6

gabogg referenced this issue

2026-09-19 17:41:35 +00:00

docs: standardize repo docs and scaffold agentic-coding config #6

gabogg referenced this issue from a commit

2026-09-19 17:52:59 +00:00

docs: apply round-2 review remediations

gabogg referenced this issue

2026-09-19 18:11:01 +00:00

docs: standardize repo docs and scaffold agentic-coding config #6

gabogg changed title from ~~Orphaned routes: /general and the 8 /[slug]-[mode] pages are not linked from any page~~ to Orphaned routes: /general and the 24 /[slug]-[style]-[mode] pages have no entry point

2026-09-19 19:46:00 +00:00

gabogg referenced this issue

2026-09-19 19:46:52 +00:00

docs: standardize repo docs and scaffold agentic-coding config #6

gabogg referenced this issue from a commit

2026-09-19 20:11:36 +00:00

docs: apply round-4 review remediations

gabogg referenced this issue

2026-09-19 20:13:22 +00:00

docs: standardize repo docs and scaffold agentic-coding config #6

gabogg referenced this issue

2026-09-19 20:21:36 +00:00